Skip to content

LG-13033: Reuse registration page for resending email confirmation#10404

Merged
aduth merged 3 commits intomainfrom
aduth-lg-13033-sign-up-email-resend
Apr 11, 2024
Merged

LG-13033: Reuse registration page for resending email confirmation#10404
aduth merged 3 commits intomainfrom
aduth-lg-13033-sign-up-email-resend

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Apr 10, 2024

🎫 Ticket

LG-13033

🛠 Summary of changes

Removes the dedicated "Resend email confirmation" screen for new user email registration in favor of redirecting the user to the "Create an account" page. This simplifies the codebase, and resolves some inconsistencies in how we validate accepted rules of use.

📜 Testing Plan

  1. Go to http://localhost:3000/rails/mailers/user_mailer/email_confirmation_instructions
  2. Click "Confirm email address"
  3. Observe you are sent to the "Create an account" screen with an error message about invalid confirmation link
  4. Continue account creation
  5. Observe that after entering email and agreeing to Rules of Use, page submits successfully

👀 Screenshots

Before After
image image

aduth added 2 commits April 10, 2024 11:39
changelog: Bug Fixes, Sign Up, Avoid prompting for Rules of Use on resent email confirmation
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big fan of the simplification!

@aduth aduth merged commit e4b127c into main Apr 11, 2024
@aduth aduth deleted the aduth-lg-13033-sign-up-email-resend branch April 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants